[ovs-dev] [PATCH] ofproto-dpif: Install internal rule should not change the match content.

Ben Pfaff blp at nicira.com
Fri May 16 04:03:24 UTC 2014


On Mon, May 12, 2014 at 10:30:04AM -0700, Andy Zhou wrote:
> Without this patch, the match passed into to
> ofproto_dpif_add_internal_flow() are modified. The mask of dl_type will
> always be converted from wildcarded match into exact match due to
> calling rule_dpif_lookup_in_table(). The fix makes sure
> ofproto_dpif_add_internal_flow() does not change the original match,
> and makes the match passed as const in the
> ofproto_dpif_add_internal_flow() API.
> 
> This bug prevents bond module from properly tracking the post
> recirculation rules installed in the internal table. The existing rule
> is always deleted followed by reinstalling of the same rule.
> 
> The observable behavior of the bug is that bond module losses track
> of the slave's stats, after the slave is rebalanced. Although traffic
> flows through the slave just fine.
> 
> Bug #1229225
> 
> Signed-off-by: Andy Zhou <azhou at nicira.com>

Good catch.

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list