[ovs-dev] [PATCH] acinclude.m4: Fix "sparse", via detection of GNU make "if" directive.

YAMAMOTO Takashi yamamoto at valinux.co.jp
Mon May 19 07:17:32 UTC 2014


> Make treats tabs very differently from spaces at the beginning of a line,
> so this test must use a tab instead of a space.  This partially reverts
> commit a0903134d2d60 (acinclude.m4: Expand tabs).
> 
> Without this commit, the build system never enables checking with sparse
> because it never detects that GNU make "if" works.
> 
> CC: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
> Signed-off-by: Ben Pfaff <blp at nicira.com>

thanks.

Acked-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>

> ---
>  acinclude.m4 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/acinclude.m4 b/acinclude.m4
> index 230c033..5ed02d2 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -490,7 +490,7 @@ AC_DEFUN([OVS_CHECK_MAKE_IF],
>       [ovs_cv_gnu_make_if],
>       [cat <<'EOF' > conftest.mk
>  conftest.out:
> -        echo $(if x,y,z) > conftest.out
> +	echo $(if x,y,z) > conftest.out
>  .PHONY: all
>  EOF
>        rm -f conftest.out
> -- 
> 1.9.1
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list