[ovs-dev] [PATCH 2/2] ovs-dev.py: Run tests in parallel.

Joe Stringer joestringer at nicira.com
Mon May 19 08:36:59 UTC 2014


On 19 May 2014 19:53, Lori Jakab <lojakab at cisco.com> wrote:

> On 5/19/14, 10:13 AM, YAMAMOTO Takashi wrote:
>
>> Signed-off-by: Joe Stringer <joestringer at nicira.com>
>>> ---
>>>   utilities/ovs-dev.py |    2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py
>>> index 97fab6c..d979afd 100755
>>> --- a/utilities/ovs-dev.py
>>> +++ b/utilities/ovs-dev.py
>>> @@ -144,7 +144,7 @@ commands.append(make)
>>>       def check():
>>> -    flags = ""
>>> +    flags = "-j8 "
>>>       if options.tests:
>>>           flags += options.tests
>>>       ENV["TESTSUITEFLAGS"] = flags
>>> --
>>> 1.7.10.4
>>>
>> -j8 seems too big to hardcode as the memory requirement of
>> some tests is rather high.
>
>
Out of curiousity, do you know what the memory requirement is? I couldn't
tell the difference on my machine.



> Additionally, it used to trigger some race conditions for me in the past,
> casing test failures that didn't occur without parallelism.


I think this has gotten a lot better (I've been running tests like this for
several months), although I agree that it occasionally presents race
conditions that otherwise don't show.


Thanks for the feedback. It's probably easier to make it a commandline
option, so I'll resend.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20140519/112900f4/attachment-0005.html>


More information about the dev mailing list