[ovs-dev] [PATCH] acinclude.m4: Fix "sparse", via detection of GNU make "if" directive.
Ben Pfaff
blp at nicira.com
Mon May 19 14:53:18 UTC 2014
On Mon, May 19, 2014 at 04:17:32PM +0900, YAMAMOTO Takashi wrote:
> > Make treats tabs very differently from spaces at the beginning of a line,
> > so this test must use a tab instead of a space. This partially reverts
> > commit a0903134d2d60 (acinclude.m4: Expand tabs).
> >
> > Without this commit, the build system never enables checking with sparse
> > because it never detects that GNU make "if" works.
> >
> > CC: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
>
> thanks.
>
> Acked-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
Thanks for the review. Applied to master and branch-2.3.
More information about the dev
mailing list