[ovs-dev] [PATCH v4] ofproto: Add reference count for Openflow groups.

Joe Stringer joestringer at nicira.com
Wed May 21 00:30:22 UTC 2014


On 21 May 2014 02:52, Ryan Wilson <wryan at nicira.com> wrote:

> When adding support for Openflow group and bucket stats, a group entry is
> added
> to the xlate cache. If the group is removed from ofproto configuration, we
> need
> to guarantee the group exists in the case where stats are attributed to the
> group by a handler thread and the xlate cache has not yet been cleared by a
> revalidator thread.


A bit more accurate would be:

"When adding support for OpenFlow group and bucket stats, a group entry is
added
to the xlate_cache. If the main thread removes the group from an ofproto,
we need to
guarantee that remains accessible to users of the xlate_cache, as the
xlate_cache
will not be cleaned up until the corresponding datapath flows are
revalidated."

(Reiterating, on current master the handler threads don't handle
xlate_cache at all, although I'm working on changing this)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20140521/243113dc/attachment-0005.html>


More information about the dev mailing list