[ovs-dev] [PATCH] makefile.am: Apply printf check only to OVS userspace.
Jesse Gross
jesse at nicira.com
Fri May 23 16:03:35 UTC 2014
We shouldn't restrict printf specifiers in kernel or third party
code.
Signed-off-by: Jesse Gross <jesse at nicira.com>
---
Makefile.am | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 0b59280..a98541f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -209,7 +209,8 @@ config-h-check:
ALL_LOCAL += printf-check
printf-check:
@if test -e $(srcdir)/.git && (git --version) >/dev/null 2>&1 && \
- git --no-pager grep -n -E -e '%[-+ #0-9.*]*([ztj]|hh)' --and --not -e 'ovs_scan' `git ls-files $(srcdir) | grep '\.[ch]$$'`; \
+ git --no-pager grep -n -E -e '%[-+ #0-9.*]*([ztj]|hh)' --and --not -e 'ovs_scan' `git ls-files $(srcdir) | grep '\.[ch]$$' | \
+ grep -vE '^datapath|^lib/sflow|^third-party'`; \
then \
echo "See above for list of violations of the rule that"; \
echo "'z', 't', 'j', 'hh' printf() type modifiers are"; \
--
1.9.1
More information about the dev
mailing list