[ovs-dev] [PATCH 1/5] dpif-netdev: batch packet receiving

Pravin Shelar pshelar at nicira.com
Fri May 23 21:16:02 UTC 2014


On Fri, May 23, 2014 at 11:37 AM, Ethan Jackson <ethan at nicira.com> wrote:
> I don't totally get why we changed the prototype for
> dp_netdev_flow_used() and dp_netdev_count_packets().  All the callers
> seem to use the old semantics.
>
> I'd replace the variable "int c" with "int cnt" to be consistent with
> netdev_rxq_recv().  I also think it's a bit easier to tell what it is.
>
> Otherwise LGTM, Pravin may want to give it a once over though.
>

I want to review this, Most likely I will finish it next week.



More information about the dev mailing list