[ovs-dev] [PATCH 14/18] dpif-xlate: Add multicast snooping sending functions

Flavio Leitner fbl at redhat.com
Sat May 24 00:46:53 UTC 2014

On Tue, May 20, 2014 at 03:41:55PM -0700, Ben Pfaff wrote:
> On Fri, Apr 11, 2014 at 06:34:19PM -0300, Flavio Leitner wrote:
> > This patch adds the functions needed for multicast snooping
> > in order to send the packets to the correct ports.
> > 
> > They are marked as OVS_UNUSED for now.
> > 
> > Acked-by: Thomas Graf <tgraf at redhat.com>
> > Signed-off-by: Flavio Leitner <fbl at redhat.com>
> I think these are OK.
> Do the NULL cases (e.g. "mcast group port is unknown, dropping")
> indicate bugs, or can they happen in normal operation?

Good question. My understanding is that they should not happen,
but to be honest, I didn't fully understand the life cycle of
xbundle to know if there is a transient state where this could
happen, so I followed what is in mac-learning.c.

> I think it would be best to squash this with whatever commit
> introduces the first user, dropping the OVS_UNUSED.



More information about the dev mailing list