[ovs-dev] [PATCH 1/2] tests: Clean up idltest on distclean.

Ben Pfaff blp at nicira.com
Wed May 28 21:29:54 UTC 2014


Well, maybe separate distcleancheck should work too.  I don't know.
The automake manual only talks about it in the context of distcheck,
though.

On Thu, May 29, 2014 at 09:26:15AM +1200, Joe Stringer wrote:
> Ahuh! Yes, I was running distcleancheck separately. I suppose that would
> explain it. I'll take a look at your patch.
> 
> 
> On 29 May 2014 05:37, Ben Pfaff <blp at nicira.com> wrote:
> 
> > I tried running "make distcheck", which includes a call to
> > distcleancheck, and only found one problem.  I sent out a patch:
> >         http://openvswitch.org/pipermail/dev/2014-May/040737.html
> >
> > I don't know why you would get different results.  Are you running
> > distcleancheck separately from distcheck?  I've never tried that.
> >
> > On Wed, May 28, 2014 at 05:34:28PM +1200, Joe Stringer wrote:
> > > Right, I didn't see that before.
> > >
> > > So I'm a bit confused why the distcleancheck target is complaining about
> > > these files. Are the ovsidl test files added to OVSIDL_BUILT after it is
> > > added to EXTRA_DIST?
> > >
> > > I see it complaining about lib/socket-util-unix.{lo,o} now, too.
> > >
> > >
> > > On 28 May 2014 03:11, Ben Pfaff <blp at nicira.com> wrote:
> > >
> > > > On Tue, May 27, 2014 at 01:46:59PM +1200, Joe Stringer wrote:
> > > > > This was causing failures in 'make distcleancheck'.
> > > > >
> > > > > Signed-off-by: Joe Stringer <joestringer at nicira.com>
> > > >
> > > > OVSIDL_BUILT is already in EXTRA_DIST.  It doesn't make sense to have
> > > > files be both distributed and distcleaned.
> > > >
> >



More information about the dev mailing list