[ovs-dev] [PATCH] vtep: Don't try to both distribute and distclean the manpage.

Joe Stringer joestringer at nicira.com
Wed May 28 21:48:13 UTC 2014


Looks good to me.

Acked-by: Joe Stringer <joestringer at nicira.com>


On 29 May 2014 05:36, Ben Pfaff <blp at nicira.com> wrote:

> Since the initial checkin of the vtep code, the manpage has been both
> distributed and distcleaned.  That's contradictory.  This commit fixes it.
>
> This commit also moves the vtep manpage from the source directory to the
> build directory.  There's no real reason for the manpage to be in the
> source directory, and it can't be if it's not distributed (because "make"
> is not supposed to update the source directory in a freshly untarred
> source distribution, and doing so breaks "make distcheck").
>
> Found by "make distcheck".
>
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> CC: Joe Stringer <joestringer at nicira.com>
> ---
>  vtep/automake.mk |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/vtep/automake.mk b/vtep/automake.mk
> index a15a067..ddf9455 100644
> --- a/vtep/automake.mk
> +++ b/vtep/automake.mk
> @@ -45,8 +45,8 @@ endif
>  # VTEP schema documentation
>  EXTRA_DIST += vtep/vtep.xml
>  DISTCLEANFILES += vtep/vtep.5
> -dist_man_MANS += vtep/vtep.5
> -$(srcdir)/vtep/vtep.5: \
> +man_MANS += vtep/vtep.5
> +vtep/vtep.5: \
>         ovsdb/ovsdb-doc vtep/vtep.xml vtep/vtep.ovsschema $(VTEP_PIC)
>         $(OVSDB_DOC) \
>                 --title="vtep" \
> --
> 1.7.10.4
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20140529/c31033f3/attachment-0005.html>


More information about the dev mailing list