[ovs-dev] [PATCH 1/5] ovs-ofctl:To set importance of a rule for eviction(OF14)

[Rishi Bamba]

Hi Ben,

> > From: rishibamba <rishibamba at users.noreply.github.com>
> > 
> > This patch enables a user to set importance for a new rule via
> > add-flow
> > OF1.1+ in the OVS and display the same via dump-flows command
> > OF1.1+ .
> > The changes are made in accordance with OpenFlow 1.4 specs to
> > implement
> > Eviction on the basis of "importance".
> > 
> > Signed-off-by: Rishi Bamba <rishi.bamba at tcs.com>
> 
> Thanks for the patch!  It applies properly to my tree.  I am glad
> that
> you were able to work out how to send patches by email.

Yeah we managed to work it out.Thanks for your support and guidance.
 
> In ofputil_decode_flow_mod(), I would only take the importance from
> the flow_mod if it is for OpenFlow 1.4 or later.  Similarly for
> ofputil_encode_flow_mod(), ofputil_decode_flow_stats_reply(), and
> ofputil_append_flow_stats_reply().

We have made the aforementioned changes. Earlier the functions were
operating on 1.1+ , now the changes are made for 1.4+.
 
> I see that this patch adds an 'importance' field to struct
> ofputil_flow_removed, but I don't see any code that reads or writes
> it
> or encodes or decodes it.  Please correct that.

We noticed the same and we have already removed that in the 5th patch i.e "[5/5] ovs-ofctl : Setting of importance parameter".
You can review the same in the final patch again.
 
> I look forward to the next version of the patch (it looks like there
> should only be one, not five).

Yes, accordingly we have squashed all the 5 patches into one single commit and the above mentioned changes have been
incorporated in the final patch.We will be submitting the same.
Hope the patch is now ready.

Thanks & Regards
Rishi Bamba
=====-----=====-----=====
Notice: The information contained in this e-mail
message and/or attachments to it may contain 
confidential or privileged information. If you are 
not the intended recipient, any dissemination, use, 
review, distribution, printing or copying of the 
information contained in this e-mail message 
and/or attachments to it are strictly prohibited. If 
you have received this communication in error, 
please notify us by reply e-mail or telephone and 
immediately and permanently delete the message 
and any attachments. Thank you