[ovs-dev] [PATCH] datapath-windows: Update port property

[Eitan Eliahu]

Hi Nithin,
Actually ovsState will get updated from portParam->PortState in OvsInitVportWithPortParam()  so this should not be an issue.
But, there may be an issue with the nic parameters stored in the voprt.
Even when the documentation reads that only "currently" the port friendly name could get updated I would rather not count on it.
I will check into this issue.
Thanks,
Eitan

-----Original Message-----
From: Nithin Raju 
Sent: Wednesday, November 05, 2014 12:55 PM
To: Eitan Eliahu
Cc: dev at openvswitch.org
Subject: Re: [PATCH] datapath-windows: Update port property


> +    case OID_SWITCH_PORT_UPDATED:
> +        HvDeletePort(switchObject, portParam);
> +        status = HvCreatePort(switchObject, portParam);
> +       break;

hi Eitan,
While this change is ok in general, can you pls. comment on how this code will work if the port is in CONNECTED state, and we get a SWITCH_PORT_UPDATED oid? HvDeletePort() might free up the vport completely, and if HvCreatePort() will render the vport->ovsState in OVS_STATE_PORT_CREATED rather than OVS_STATE_CONNECTED. Some more fixes might need to be done for this code to work. Did you get a chance to test this code on a NIC that is already connected?

thanks,
Nithin