[ovs-dev] [PATCH v3 1/3] rule_dpif_lookup_from_table: Check frags only once.

Jarno Rajahalme jrajahalme at nicira.com
Thu Nov 6 23:43:44 UTC 2014


On Nov 6, 2014, at 3:32 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Wed, Nov 05, 2014 at 02:48:41PM -0800, Jarno Rajahalme wrote:
>> Move the frags handling check up in the call chain, so that it is done
>> once for each rule_dpif_lookup_from_table() call.
>> 
>> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> rule_dpif_lookup_from_table() is close to the point where it would be
> cleaner to use a wrapper function that only saves and restores the
> transport ports.  Then the "goto"s could be avoided.  But I am not sure
> that it crosses that point.

I also thought about this yesterday evening, and I think I should more
at least the in_port change back to the resubmit caller, as other callers
do not need it.

  Jarno

> 
> Acked-by: Ben Pfaff <blp at nicira.com>




More information about the dev mailing list