[ovs-dev] [PATCH] ofproto: Fix supported group types.

[Shu Shen]

Ben,

You are correct. I've corrected it and submitted v2 of the patch.

Thanks,
Shu

-----Original Message-----
From: Ben Pfaff [mailto:blp at nicira.com] 
Sent: Monday, November 10, 2014 3:57 PM
To: Shu Shen
Cc: dev at openvswitch.org
Subject: Re: [ovs-dev] [PATCH] ofproto: Fix supported group types.

On Mon, Nov 10, 2014 at 02:41:21PM -0800, Shu Shen wrote:
> Previously the types field is uninited and leds to no supported type
> being reported in OFPMP_GROUP_FEATURES message.
> 
> Signed-off-by: Shu Shen <shu.shen at radisys.com>
> ---
>  ofproto/ofproto.c |  3 +++
>  tests/ofproto.at  | 11 ++++++++++-
>  2 files changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
> index 6be338a..2648a96 100644
> --- a/ofproto/ofproto.c
> +++ b/ofproto/ofproto.c
> @@ -523,6 +523,9 @@ ofproto_create(const char *datapath_name, const char *datapath_type,
>      ovs_rwlock_init(&ofproto->groups_rwlock);
>      hmap_init(&ofproto->groups);
>      ovs_mutex_unlock(&ofproto_mutex);
> +
> +    /* No support for OFPGT11_FF per init_group() */
> +    ofproto->ogf.types = 0x7;

init_group() checks the group type like this:
    if (gm->type > OFPGT11_FF) {
        return OFPERR_OFPGMFC_BAD_TYPE;
    }
To me, this looks like OFPGT11_FF is supported.