[ovs-dev] [PATCH 03/22] ofp-errors: Add (draft) OpenFlow 1.5 errors

Simon Horman simon.horman at netronome.com
Tue Nov 11 00:42:53 UTC 2014


On Mon, Nov 10, 2014 at 09:43:01AM -0800, Ben Pfaff wrote:
> On Mon, Nov 10, 2014 at 01:47:50PM +0900, Simon Horman wrote:
> > Add OFPERR_OFPGMFC_UNKNOWN_BUCKET and OFPERR_OFPGMFC_BUCKET_EXISTS
> > which are part of (draft) OpenFlow 1.5 groups.
> > 
> > EXT-350
> 
> Please write "ONF-JIRA: EXT-350" as suggested in CONTRIBUTING.md.
> 
> > Signed-off-by: Simon Horman <simon.horman at netronome.com>
> > ---
> >  lib/ofp-errors.h | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/lib/ofp-errors.h b/lib/ofp-errors.h
> > index 2516b39..40c7910 100644
> > --- a/lib/ofp-errors.h
> > +++ b/lib/ofp-errors.h
> > @@ -411,6 +411,12 @@ enum ofperr {
> >      /* OF1.2+(6,14).  Permissions error. */
> >      OFPERR_OFPGMFC_EPERM,
> >  
> > +    /* OF1.5+(6,15).  Permissions error. */
> > +    OFPERR_OFPGMFC_UNKNOWN_BUCKET,
> > +
> > +    /* OF1.5+(6,16).  Permissions error. */
> > +    OFPERR_OFPGMFC_BUCKET_EXISTS,
> 
> The comments are wrong.

Hi Ben,

thanks for your review. I plan to address these problems as follows:

From: Simon Horman <simon.horman at netronome.com>

[PATCH v1.1] ofp-errors: Add (draft) OpenFlow 1.5 errors

Add OFPERR_OFPGMFC_UNKNOWN_BUCKET and OFPERR_OFPGMFC_BUCKET_EXISTS
which are part of (draft) OpenFlow 1.5 groups.

ONF-JIRA: EXT-350
Signed-off-by: Simon Horman <simon.horman at netronome.com>

---
v1.1
* Use ONF-JIRA: EXT-350 annotation in changelog
* Use correct descriptions for the new errors
---
 lib/ofp-errors.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/lib/ofp-errors.h b/lib/ofp-errors.h
index 2516b39..1a3c4fc 100644
--- a/lib/ofp-errors.h
+++ b/lib/ofp-errors.h
@@ -411,6 +411,14 @@ enum ofperr {
     /* OF1.2+(6,14).  Permissions error. */
     OFPERR_OFPGMFC_EPERM,
 
+    /* OF1.5+(6,15).  Invalid bucket identifier used in
+     * INSERT BUCKET or REMOVE BUCKET command. */
+    OFPERR_OFPGMFC_UNKNOWN_BUCKET,
+
+    /* OF1.5+(6,16).  Can't insert bucket because a bucket
+     * already exist with that bucket-id. */
+    OFPERR_OFPGMFC_BUCKET_EXISTS,
+
 /* ## --------------------- ## */
 /* ## OFPET_PORT_MOD_FAILED ## */
 /* ## --------------------- ## */
-- 
2.1.1




More information about the dev mailing list