[ovs-dev] [PATCH v2 04/13] ofp-print: print bucket ids of OpenFlow 1.5 group messages
Ben Pfaff
blp at nicira.com
Tue Nov 11 17:02:21 UTC 2014
On Tue, Nov 11, 2014 at 12:39:20PM +0900, Simon Horman wrote:
> ONF-JIRA: EXT-350
> Signed-off-by: Simon Horman <simon.horman at netronome.com>
>
> ---
> v2
> * As suggested by Ben Pfaff
> - Use ONF-JIRA: EXT-350 annotation in changelog
Thanks.
I changed ofp_print_bucket_id() to better suit my ideas of
maintainability:
static void
ofp_print_bucket_id(struct ds *s, uint32_t bucket_id,
enum ofp_version ofp_version)
{
if (ofp_version < OFP15_VERSION) {
return;
}
ds_put_cstr(s, "bucket_id:");
switch (bucket_id) {
case OFPG15_BUCKET_FIRST:
ds_put_cstr(s, "first");
break;
case OFPG15_BUCKET_LAST:
ds_put_cstr(s, "last");
break;
case OFPG15_BUCKET_ALL:
ds_put_cstr(s, "all");
break;
default:
ds_put_format(s, "%"PRIu32, bucket_id);
break;
}
ds_put_char(s, ',');
}
and applied this to master.
More information about the dev
mailing list