[ovs-dev] [PATCH v2 09/13] ofp-util: Enhanced command error logging during encoding group mod messages

[Ben Pfaff]

On Tue, Nov 11, 2014 at 12:39:25PM +0900, Simon Horman wrote:
> In preparation for supporting (draft) OpenFlow 1.5
> group mod commands enhance the error logging of them.
> 
> ONF-JIRA: EXT-350
> Signed-off-by: Simon Horman <simon.horman at netronome.com>
> 
> ---
> v2
> * As suggested by Ben Pfaff
>   - Use ONF-JIRA: EXT-350 annotation in changelog

Using a blind array dereference into cmd_str[] in bad_group_cmd() seems
like it could easily be overlooked if new commands get added later.  I
would use a switch statement or otherwise make this more easily
maintainable.

Thanks,

Ben.