[ovs-dev] [PATCH] util: Add be32_prefix_mask().

Ben Pfaff blp at nicira.com
Wed Nov 12 00:21:31 UTC 2014


On Tue, Nov 11, 2014 at 03:41:15PM -0800, Pravin Shelar wrote:
> On Tue, Nov 11, 2014 at 3:37 PM, Jarno Rajahalme <jrajahalme at nicira.com> wrote:
> > Shifting a 32-bit entity by 32 bits is undefined behavior.  As we have 3
> > cases where we may hit this, it is a time to introduce a helper for
> > this.
> >
> > VMware-BZ: #1355026
> > Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> LGTM
> Acked-by: Pravin B Shelar <pshelar at nicira.com>

Pravin, your "userspace tunneling" patch has at least one place it
should use this, in netdev_dummy_ip4addr().

Thanks,

Ben.



More information about the dev mailing list