[ovs-dev] [PATCH v2 13/13] ovs-ofctl: Support bucket commands

[Ben Pfaff]

On Wed, Nov 12, 2014 at 01:07:26PM +0900, Simon Horman wrote:
> On Tue, Nov 11, 2014 at 09:33:08AM -0800, Ben Pfaff wrote:
> > On Tue, Nov 11, 2014 at 12:39:29PM +0900, Simon Horman wrote:
> > > (Draft) OpenFlow 1.5 flow mod commands include commands to manipulate the
> > > buckets of existing groups. This patch add support to ovs-ofctl for these
> > > commands. It also adds documentation and tests for them.
> > > 
> > > ONF-JIRA: EXT-350
> > > Signed-off-by: Simon Horman <simon.horman at netronome.com>
> > > 
> > > ---
> > > v2
> > > * As suggested by Ben Pfaff
> > >   - Use ONF-JIRA: EXT-350 annotation in changelog
> > 
> > I think that the --help text for the file-based forms of the insert and
> > remove buckets commands are wrong; isn't shell fd redirection necessary
> > for those?
> 
> Thanks. It seems to me that this is similar to the form of del-groups.
> I intend to change things as per the following incremental diff.

Sure, thanks for that.

> > I think that somewhere in here we need to update NEWS to mention the new
> > feature support.
> > 
> > Otherwise this looks good, thank you!
> 
> Thanks, I will supply an extra patch with the following change.
> 
> Feel free to squash that into "ovs-ofctl: Support bucket commands"
> which as of v2 was the last patch in the series.
> 
> diff --git a/NEWS b/NEWS
> index 5ba8f4d..1d03e8c 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -22,6 +22,7 @@ Post-v2.3.0
>       * The OpenFlow 1.5 (draft) actset_output field is now supported.
>       * OpenFlow 1.5 (draft) Copy-Field action is now supported.
>       * OpenFlow 1.5 (draft) masked Set-Field action is now supported.
> +     * OpenFlow 1.5 (draft) groups are now supported.
>       * OpenFlow 1.3+ table features requests are now supported (read-only).
>       * Nicira extension "move" actions may now be included in action sets.
>       * "resubmit" actions may now be included in action sets.  The resubmit

Great, thanks.