[ovs-dev] [PATCH 03/11] lib: Convert include/ to a automake sub directory

Ben Pfaff blp at nicira.com
Wed Nov 12 22:37:29 UTC 2014


On Wed, Nov 12, 2014 at 11:04:01PM +0100, Thomas Graf wrote:
> On 11/12/14 at 10:33am, Ben Pfaff wrote:
> > On Wed, Nov 12, 2014 at 10:26:52AM -0800, Ben Pfaff wrote:
> > > On Wed, Nov 12, 2014 at 03:06:01PM +0100, Thomas Graf wrote:
> > > > Allows for installable headers in later commits.
> > > > 
> > > > Signed-off-by: Thomas Graf <tgraf at noironetworks.com>
> > > 
> > > I strongly dislike adding SUBDIRS because they slow down builds and
> > > (especially) automake and autoconf invocation.
> > > 
> > > I think we can avoid it, though, by adding directory-specific variables,
> > > e.g.:
> > > 
> > > openflowincludedir = $(includedir)/openflow
> > > openflowinclude_HEADERS = openflow.h    # ...and so on.
> > 
> > Once we figure this out, the remaining patches make sense to me.
> 
> Sure. No problem. I'll convert it to the above.

Thanks!



More information about the dev mailing list