[ovs-dev] [PATCH 1/2] ofproto-dpif-xlate: Allow direct destroy of previous config.

Alex Wang alexw at nicira.com
Wed Nov 12 23:59:39 UTC 2014


Thx applied to master,

On Tue, Nov 11, 2014 at 2:43 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Fri, Nov 07, 2014 at 02:51:42PM -0800, Alex Wang wrote:
> > Before this commit, the ofproto-dpif-xlate module uses ovs-rcu to
> > postpone the destroy of previous configuration.  However, the delayed
> > close of object like 'struct netdev' could cause failure in immediate
> > re-add or reconfigure of the same device.
> >
> > To fix the above issue, this commit makes the ofproto-dpif-xlate
> > module call ovsrcu_synchronize(), which waits for all threads
> > to finish the use of reference to previous config.  Then, the
> > module can just directly destroy the previous config.
> >
> > Reported-by: Cian Ferriter <cian.ferriter at intel.com>
> > Signed-off-by: Alex Wang <alexw at nicira.com>
>
> Acked-by: Ben Pfaff <blp at nicira.com>
>
> I don't maintain dpif-netdev so I'll leave patch 2 for Pravin or
> someone else who knows it better.
>



More information about the dev mailing list