[ovs-dev] [PATCH] ofproto: Test that group commands fail for OpenFlow 1.0

Ben Pfaff blp at nicira.com
Thu Nov 13 02:32:34 UTC 2014


On Thu, Nov 13, 2014 at 10:37:57AM +0900, Simon Horman wrote:
> On Wed, Nov 12, 2014 at 09:30:57AM -0800, Ben Pfaff wrote:
> > On Wed, Nov 12, 2014 at 08:58:13AM -0800, Ben Pfaff wrote:
> > > On Wed, Nov 12, 2014 at 03:45:17PM +0900, Simon Horman wrote:
> > > > Groups are not supported by OpenFlow 1.0
> > > > 
> > > > Signed-off-by: Simon Horman <simon.horman at netronome.com>
> > > > 
> > > > ---
> > > > * This is a follow up to "ovs-ofctl: Only allow usable protocols for group
> > > >   commands" requested by Ben Pfaff.
> > > > 
> > > > * A further possible follow up is to test that group bucket commands
> > > >   fail for OpenFlow < 1.5 once support for those commands has
> > > >   been merged.
> > > 
> > > Applied, thanks!
> > > 
> > > On your second point above, another more user-friendly possibility would
> > > be to make ovs-ofctl dump the group, modify it as the user requested,
> > > and then update the group.
> > 
> > Or maybe that wouldn't be useful because bucket IDs aren't user-assigned
> > in that case.  Dunno.
> 
> From my point of view bucket ids are required in order for the
> bucket commands to operate, though it may be possible define a very restricted
> subset of their operation. For this reason it seems to me that
> it would be tricky to implement a compatibility mode bucket operations.

Let's leave it as-is, then.  Thanks for thinking about it.



More information about the dev mailing list