[ovs-dev] [PATCH 11/11] rhel: Include pkgconfig and header files in Fedora package

Thomas Graf tgraf at noironetworks.com
Thu Nov 13 11:10:17 UTC 2014


On 11/12/14 at 04:06pm, Flavio Leitner wrote:
> On Wed, Nov 12, 2014 at 03:06:09PM +0100, Thomas Graf wrote:
> > Ignore both pkgconfig and headers in RHEL package for now as there
> > is no -devel package yet.
> 
> Now we have the openvswitch-fedora.spec installing the headers
> during ``make install´´ and then later manually using ``install´´
> command in the %install section.  The only difference is that
> the spec file is installing include/openvswitch/lib and config.h
> as well.
> 
> Can we remove the redundancy?

I was reluctant to remove anything from the package as there might be
users depending on it. OTOH, providing lib/ as-is in public headers is
certainly broken as it heavily pollutes the namespace.

Providing config.h seems pointless too. Whatever was available on the
build machine can't be taken for granted on another build machine.

I'll explain this in v2 and let you comment on it.



More information about the dev mailing list