[ovs-dev] [PATCH] tests: Skip tunnel-push-pop test on Windows and BSD.

YAMAMOTO Takashi yamamoto at valinux.co.jp
Fri Nov 14 04:09:31 UTC 2014


> diff --git a/tests/atlocal.in b/tests/atlocal.in
> index 825d289..bada7e2 100644
> --- a/tests/atlocal.in
> +++ b/tests/atlocal.in
> @@ -93,13 +93,19 @@ FreeBSD|NetBSD)
>      ;;
>  esac
>  
> -# Check for MINGW platform.
> +# Check for platform.
>  case `uname` in
>  MINGW*)
>      IS_WIN32="yes"
> +    IS_BSD="no"
> +    ;;
> +FreeBSD|NetBSD)
> +    IS_WIN32="no"
> +    IS_BSD="yes"
>      ;;
>  *)
>      IS_WIN32="no"
> +    IS_BSD="no"
>      ;;
>  esac

IS_xxx does not seem to scale.
it isn't your fault, though.

> diff --git a/tests/tunnel-push-pop.at b/tests/tunnel-push-pop.at
> index 44c2ecf..6654567 100644
> --- a/tests/tunnel-push-pop.at
> +++ b/tests/tunnel-push-pop.at
> @@ -2,6 +2,9 @@ AT_BANNER([tunnel_push_pop])
>  
>  AT_SETUP([tunnel_push_pop - action])
>  
> +AT_SKIP_IF([test "$IS_WIN32" = "yes"])
> +AT_SKIP_IF([test "$IS_BSD" = "yes"])

it's better to add a comment explaining why to skip.
otherwise looks good to me.

Acked-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>



More information about the dev mailing list