[ovs-dev] [PATCH v4 5/5] classifier: Defer pvector publication.

Ben Pfaff blp at nicira.com
Fri Nov 14 22:04:35 UTC 2014


On Thu, Nov 13, 2014 at 11:56:17AM -0800, Jarno Rajahalme wrote:
> This patch adds a new functions classifier_defer() and
> classifier_publish(), which control when the classifier modifications
> are made available to lookups.  By default, all modifications are made
> available to lookups immediately.  Modifications made after a
> classifier_defer() call MAY be 'deferred' for later 'publication'.  A
> call to classifier_publish() will both publish any deferred
> modifications, and cause subsequent changes to to be published
> immediately.
> 
> Currently any deferring is limited to the visibility of the subtable
> vector changes.  pvector now processes modifications mostly in a
> working copy, which needs to be explicitly published with
> pvector_publish().  pvector_publish() sorts the working copy and
> removes gaps before publishing it.
> 
> This change helps avoiding O(n**2) memory behavior in corner cases,
> where large number of rules with different masks are inserted or
> deleted.
> 
> VMware-BZ: #1322017
> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> Summary:

I don't know of a "Summary:" tag.

I think that pvector.h deserves at least a brief comment describing
the two different copies.

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list