[ovs-dev] [PATCH] datapath-windows: update DESIGN document

[Nithin Raju]

hi Sorin,
Thanks for the patient review.

The document should not rever to ovs-wind anymore since the model of adding vport is changed to be "friendly-name" based. I'll clean it up for that.

I have addressed all your comments as you suggested except the ones below.

> Due to these differences, it was a straightforward decision to develop the @@ -159,13 +156,17 @@ called ovs-wind. At a high level ovs-wind manages keeps the ovsdb used by  userspace in sync with the kernel state. More details in the userspace section.
> [Sorin]: Please also reformulate the above phrase to something like:
> " At a high level ovs-wind keeps the ovsdb, used by userspace, in sync with the kernel state. More details in the userspace section.".

Will clean up references to ovs-wind.


> +Netlink sockets
> +---------------
> +On Linux, OVS userspace utilizes netlink sockets to pass back and forth 
> +netlink messages. Since much of userspace code including DPIF provider 
> +in dpif-netlink.c (formerly dpif-linux.c) has been reused, 
> [Sorin]: The dpif-netlink.c history is already provided above, so the duplicate explanation in the parenthesis should be removed.

There's going to be some redundant information like this for example for components which are implemented partly in the kernel and partly in userspace. I just want to repeat this information here for readers who are impatient and jump sections. Hope that is ok.

> +DPIF provider
> +--------------
> +As has been alluded to in earlier sections, the netlink socket and 
> +netlink message based DPIF provider on Linux has been ported to Windows.
> +Correspondingly, the file is called lib/dpif-netlink.c now from its 
> +former name of lib/dpif-linux.c.

> [Sorin]: I propose the following formulation:
> "As has been mentioned in earlier sections, the netlink socket and 
> netlink message, based on the Linux's DPIF provider, has been ported to Windows.
> Correspondingly, the file lib/dpif-netlink.c was renamed to lib/dpif-linux.c."

We are specifically talking about the DPIF provider, and hence I want to say "netlink socket and netlink message based DPIF provider".

Thanks,
-- Nithin