[ovs-dev] [PATCH] datapath-windows: Support for hybrid forwarding

[Nithin Raju]

On Nov 21, 2014, at 8:23 AM, Eitan Eliahu <eliahue at vmware.com>
 wrote:

> Hi Sorin,
> This change applies only for 6.40 drivers. Unless we bump the driver version this code has no effect.
> You may want to bump the minor version.
> 
> #define NDIS_FILTER_MAJOR_VERSION 6
> #define NDIS_FILTER_MINOR_VERSION 30  <------------ 40
> 
>    driverChars.MajorNdisVersion = NDIS_FILTER_MAJOR_VERSION;
>    driverChars.MinorNdisVersion = NDIS_FILTER_MINOR_VERSION;

+1 to that.

Also, we should use the following macro around the new code being added. Also, when we bump up the version, we should use the macro.
#if (NDIS_SUPPORT_NDIS640)

#endif

Thanks for the patch Sorin! I'll review it once the macros are added to make the code conditional.

-- Nithin