[ovs-dev] [PATCH] tests/ovs_client: Remove broken debug code

[Pravin Shelar]

On Wed, Nov 19, 2014 at 4:03 AM, Stephen Finucane
<stephen.finucane at intel.com> wrote:
> There is some debug "logging" code included in the 'ovs_client'
> application. This code appears to be broken as it spams stdout with
> duplicated "log" messages. Remove this code.
>
> In addition, add the 'ovsclient' executable to the 'tests/.gitignore'
> file.
>
> Signed-off-by: Stephen Finucane <stephen.finucane at intel.com>

I also renamed ovsclient to test-dpdkr and pushed patch to master.

Thanks.

> ---
>  tests/.gitignore              |  1 +
>  tests/ovs_client/ovs_client.c | 11 -----------
>  2 files changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/tests/.gitignore b/tests/.gitignore
> index 908c50e..02fc822 100644
> --- a/tests/.gitignore
> +++ b/tests/.gitignore
> @@ -7,6 +7,7 @@
>  /idltest.h
>  /idltest.ovsidl
>  /ovstest
> +/ovsclient
>  /ovs-pki.log
>  /pki/
>  /test-aes128
> diff --git a/tests/ovs_client/ovs_client.c b/tests/ovs_client/ovs_client.c
> index 6387624..97d32fc 100644
> --- a/tests/ovs_client/ovs_client.c
> +++ b/tests/ovs_client/ovs_client.c
> @@ -58,9 +58,6 @@
>   */
>  static uint8_t client_id = 0;
>
> -int no_pkt;
> -int pkt;
> -
>  /*
>   * Given the rx queue name template above, get the queue name.
>   */
> @@ -209,18 +206,10 @@ main(int argc, char *argv[])
>          }
>
>          if (rx_pkts > 0) {
> -            pkt++;
>              /* blocking enqueue */
>              do {
>                  rslt = rte_ring_enqueue_bulk(tx_ring, pkts, rx_pkts);
>              } while (rslt == -ENOBUFS);
> -        } else {
> -               no_pkt++;
> -        }
> -
> -        if (!(pkt %  100000)) {
> -            printf("pkt %d %d\n", pkt, no_pkt);
> -            pkt = no_pkt = 0;
>          }
>      }
>  }
> --
> 1.9.3
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev