[ovs-dev] [PATCH/RFC 0/9] Group Select: Selection Method Extension

Ben Pfaff blp at nicira.com
Tue Nov 25 23:30:01 UTC 2014


On Wed, Nov 19, 2014 at 09:44:54AM +0900, Simon Horman wrote:
> this patch set implements the group select selection method extension that
> I circulated some months ago on the dev at openvswtich.org mailing list.  For
> reference a copy of that proposal (updated for the existence of an Open
> Flow 1.5 draft and several errors found during implementation) is at the
> end of this email.
> 
> The implementation makes use of a group experimenter property and
> thus depends on my recent work to implement (draft) Open Flow 1.5
> groups (ONF EXT-250). That work is already present in the master branch.
> 
> The last patch of the series adds an implementation of a hash selection
> method to illustrate what a selection method might look like.  It may be
> thought of as a less intelligent but more flexible than the default
> selection method which I characterise as making hash of L2 and/or L3 fields
> depending on which fields are present in the flow.

Hi Simon.  Thanks for submitting this.

I have a question about the status of the definition of this
extension.  Is it an extension that is already in use, so that the OVS
implementation should strive to be compatible with the existing
implementation?  Or is it an extension for which this will be the
first implementation?  The answer colors my review, since in the first
case I'm mostly interested in faithfully implementing the extension in
an interoperable way, whereas in the second I'm also interested in
trying to ensure that it is defined in a way that is likely to be
useful and maintainable and extensible in the long run.

Thanks,

Ben.



More information about the dev mailing list