[ovs-dev] [PATCH 04/10] lib: Use MAP_FOR_EACH_INDEX to improve readability.

Ben Pfaff blp at nicira.com
Wed Nov 26 00:19:30 UTC 2014


On Thu, Nov 20, 2014 at 04:42:51PM -0800, Jarno Rajahalme wrote:
> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>

In most of the cases this just improves readability and should not
change the generated code much if at all.  In miniflow_hash(), though,
the previous code did not need to use raw_ctz(), which is relatively
expensive when no machine-specific implementation is available, but
the new version does use it.  Maybe that is OK, but it is a trade-off
that the other changes in this patch do not make.

Ditto for miniflow_equal().

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list