[ovs-dev] [PATCH 1/2] lib: Clean up vlog use.

Jarno Rajahalme jrajahalme at nicira.com
Thu Oct 23 21:15:53 UTC 2014


Vlog functions assume a vlog module has been defined for the current
translation unit.  Including lib/vlog.h from a header file makes the
vlog API visible even when no vlog module may not have been defined.
This patch removes the two cases in the tree where vlog.h was included
from a header file.

Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
---
 lib/coverage.h |    1 -
 lib/stream.h   |    3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/coverage.h b/lib/coverage.h
index af0bdfe..832c433 100644
--- a/lib/coverage.h
+++ b/lib/coverage.h
@@ -28,7 +28,6 @@
  * a useful debugging tool. */
 
 #include "ovs-thread.h"
-#include "vlog.h"
 #include "compiler.h"
 
 /* Makes coverage_run run every 5000 ms (5 seconds).
diff --git a/lib/stream.h b/lib/stream.h
index 3780ff9..3087f45 100644
--- a/lib/stream.h
+++ b/lib/stream.h
@@ -22,11 +22,12 @@
 #include <stdint.h>
 #include <sys/types.h>
 #include "openvswitch/types.h"
-#include "vlog.h"
 #include "socket-util.h"
+#include "util.h"
 
 struct pstream;
 struct stream;
+struct vlog_module;
 
 void stream_usage(const char *name, bool active, bool passive, bool bootstrap);
 
-- 
1.7.10.4




More information about the dev mailing list