[ovs-dev] [PATCH 02/14] datapath-windows: Rename hyper-v switch port and nic handlers

Nithin Raju nithin at vmware.com
Fri Oct 3 17:23:12 UTC 2014


On Sep 30, 2014, at 7:44 AM, Samuel Ghinet <sghinet at cloudbasesolutions.com> wrote:

> Functions such as OvsCreatePort are vague in regard to who creates it or
> when. It wasn't a problem thus far, since the vports were created,
> updated and destroyed from one place only (hyper-v switch part). But
> now, with the netlink implementation of the vport commands, a part of
> the vport is constructed by the netlink vport add, and the other part
> is constructed by the hyper-v switch nic and port handlers.
> 
> This patch renames the hyper-v switch nic and port handlers, so that
> they are now prefixed by "HvOn" instead of "Ovs", in order to clarify
> which of the functions are nic or port handlers. This will make more
> clear the usages from netlink vport commands side and from hyper-v
> switch side. It will also make more obvious which nic and port
> functions are helper functions.
> 
> Signed-off-by: Samuel Ghinet <sghinet at cloudbasesolutions.com>

Looks good.

Only suggestion I had was to call the functions:
OvsCreate*HV*Nic rather than HvOnCreateNic. Or even HVCreateNic. The 'On' doesn't seem to add a lot of clarity.

But, I don't feel very strongly.

Acked-by: Nithin Raju <nithin at vmware.com>

thanks,
Nithin



More information about the dev mailing list