[ovs-dev] [PATCH 03/14] datapath-windows: We don't need to keep validation ports in ovs

[Nithin Raju]

On Sep 30, 2014, at 7:45 AM, Samuel Ghinet <sghinet at cloudbasesolutions.com> wrote:

> Validation ports are used internally by the hyper-v switch to validate
> and verify settings for the real hyper-v switch ports that will be
> connected to the VNic. The validation ports are of no use to us - we
> must skip handling them, and return STATUS_SUCCESS as the OID result.
> 
> Signed-off-by: Samuel Ghinet <sghinet at cloudbasesolutions.com>
> ---
> datapath-windows/ovsext/Oid.c   | 4 ++++
> datapath-windows/ovsext/Vport.c | 8 +++++---
> datapath-windows/ovsext/Vport.h | 1 -
> 3 files changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/datapath-windows/ovsext/Oid.c b/datapath-windows/ovsext/Oid.c
> index 39e47c2..f67bf11 100644
> --- a/datapath-windows/ovsext/Oid.c
> +++ b/datapath-windows/ovsext/Oid.c
> @@ -159,6 +159,10 @@ OvsProcessSetOidPort(POVS_SWITCH_CONTEXT switchObject,
>         goto done;
>     }
> 
> +    if (portParam->IsValidationPort) {
> +        return NDIS_STATUS_SUCCESS;
> +    }

LG. Only comment I had was that it would be nice if we could add a comment about Validation ports when we return NDIS_STATUS_SUCCESS.

Acked-by: Nithin Raju <nithin at vmware.com>