[ovs-dev] [PATCH 06/14] datapath-windows: Rename OvsGetVportNo into OvsComputeVportNo and make public

[Ankur Sharma]

Acked-by: Ankur Sharma <ankursharma at vmware.com>
________________________________________
From: Nithin Raju
Sent: Friday, October 3, 2014 11:02 AM
To: Samuel Ghinet
Cc: dev at openvswitch.org; Alin Serdean; Eitan Eliahu; Ankur Sharma
Subject: Re: [PATCH 06/14] datapath-windows: Rename OvsGetVportNo into OvsComputeVportNo and make  public

On Sep 30, 2014, at 7:49 AM, Samuel Ghinet <sghinet at cloudbasesolutions.com> wrote:

> OvsGetVportNo computes a new port number. Therefore, OvsComputeVportNo
> is a more clear name for what the function does. Reading OvsGetVportNo
> may give the false impression that it returns the port number of an
> existing vport.
>
> Also, since the responsibility of assigning dp port numbers no longer
> falls on the hyper-v switch port handlers side, but on the netlink vport
> commands side (vport add), we will need to use this compute port number
> function from outside Vport.c. Therefore, this function declaration is
> moved from Vport.c to Vport.h, and becomes public.
>
> Signed-off-by: Samuel Ghinet <sghinet at cloudbasesolutions.com>

Acked-by: Nithin Raju <nithin at vmware.com>