[ovs-dev] [PATCH 4/7] lib/flow: Add miniflow_extract_from_flow

[Ben Pfaff]

On Wed, Oct 01, 2014 at 04:02:34PM -0700, Jarno Rajahalme wrote:
> miniflow_extract_from_flow() is faster than miniflow_init(), since it
> does not scan the fields not significant for the packet type. More
> importantly, it produces the same layout as miniflow_extract, which
> does not try to compress zero-valued packet header fields.
> 
> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>

I'm surprised that it's faster, since it's much more complex.

As for the layout, I can believe that it's the same (though it is
somewhat tricky to verify), but I wonder how to ensure that that
property is correctly maintained over time.  Do you have any thoughts?