[ovs-dev] [PATCH 4/5] lib/cmap: split up cmap_find().

Jarno Rajahalme jrajahalme at nicira.com
Mon Oct 6 22:02:25 UTC 2014


On Oct 6, 2014, at 11:00 AM, Ben Pfaff <blp at nicira.com> wrote:

> On Wed, Sep 24, 2014 at 11:31:46AM -0700, Jarno Rajahalme wrote:
>> This makes the following patch easier and cleans up the code.
>> 
>> Explicit "inline" keywords seem necessary to prevent performance
>> regression on cmap_find() with GCC 4.7 -O2.
>> 
>> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> Do you think it's worthwhile writing any of these as ALWAYS_INLINE?

I believe it only makes a difference when compiling without optimizations, so I did not think it worthwhile.

> 
> Acked-by: Ben Pfaff <blp at nicira.com>

Thanks!




More information about the dev mailing list