[ovs-dev] [PATCH 1/7] lib/match: Do not format undefined fields.

[Jarno Rajahalme]

Pushed to master,

  Jarno

On Oct 6, 2014, at 3:10 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Mon, Oct 06, 2014 at 01:53:50PM -0700, Jarno Rajahalme wrote:
>> 
>> On Oct 6, 2014, at 1:13 PM, Ben Pfaff <blp at nicira.com> wrote:
>> 
>>> On Wed, Oct 01, 2014 at 04:02:31PM -0700, Jarno Rajahalme wrote:
>>>> Add function flow_wildcards_init_for_packet() that can be used to set
>>>> sensible wildcards when megaflows are disabled.  Before this, we set
>>>> all the mask bits to ones, which caused priting tunnel, mpls, and/or
>>> 
>>> s/priting/printing/
>>> 
>>>> trasport port fields even for packets for which it makes no sense.
>>>> 
>>>> This has the side effect of generating different megaflow masks for
>>>> different packet types, so there will be more than one kind of mask in
>>>> the datapath classifier.  This should not make practical difference,
>>>> though.
>>> 
>>> How did you conclude that it will not make a practical difference?
>> 
>> If someone cares for performance, they should not disable
>> megaflows. In other words, this patch makes the ?slowness? of
>> disabled megaflows a bit worse.
> 
> I interpreted the commit message as meaning that the change increases
> the diversity of megaflow masks when megaflows are enabled.  I guess
> that doesn't make sense though.  Thanks.