[ovs-dev] [PATCH 5/7] lib/cmap: Return number of nodes from functions modifying the cmap.

Jarno Rajahalme jrajahalme at nicira.com
Mon Oct 6 22:39:35 UTC 2014


On Oct 6, 2014, at 1:39 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Wed, Oct 01, 2014 at 04:02:35PM -0700, Jarno Rajahalme wrote:
>> We already update the count field as the last step of these functions,
>> so returning the current count is very cheap.  Callers that care about
>> the count become a bit more efficient, as they avoid extra
>> non-inlineable function call.
>> 
>> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> I would update the function comments to describe the return value.
> 

Done, thanks for the review!

> Acked-by: Ben Pfaff <blp at nicira.com>

Pushed to master,

  Jarno




More information about the dev mailing list