[ovs-dev] [PATCH v2] lib/bitmap: Faster bitmap functions.

Ben Pfaff blp at nicira.com
Mon Oct 6 22:54:53 UTC 2014


On Fri, Oct 03, 2014 at 01:22:07PM -0700, Jarno Rajahalme wrote:
> Replace bitwise loops with a single operation, inline all bitmap
> functions.  Inlining allows the compiler to remove unnecessary code
> due to some parameters being compile-time constants.
> 
> Before:
> 
> $ tests/ovstest test-bitmap benchmark 1000000
> bitmap equal:    341 ms
> bitmap scan:   8089 ms
> 
> After:
> 
> $ tests/ovstest test-bitmap benchmark 1000000
> bitmap equal:    152 ms
> bitmap scan:    146 ms
> 
> Signed-off-by: Kmindg <kmindg at gmail.com>
> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>

I can't argue with the results.

I think you made significant changes to Kmindg's original patch.
You should probably either add a note saying how you changed it, e.g.

    Signed-off-by: Kmindg <kmindg at gmail.com>
    [jrajahalme at nicira.com updated this to frob the quux]
    Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>

or just change it to a co-author relationship.

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list