[ovs-dev] [PATCH v2 05/12] ofp-actions: Better support OXM in Copy-Field action.

Ben Pfaff blp at nicira.com
Tue Oct 7 22:36:09 UTC 2014


On Mon, Oct 06, 2014 at 12:00:30PM +0900, YAMAMOTO Takashi wrote:
> > The OpenFlow 1.5 (draft) Copy-Field action has two OXM headers, one after
> > the other.  Until now, Open vSwitch has implemented these as a pair of
> > ovs_be32 members, which meant that only 32-bit OXM could be supported.  This
> > commit changes the implementation to use nx_pull_header(), which means that
> > in the future when that function supports 64-bit experimenter OXMs,
> > Copy-Field will automatically get that support too.
> > 
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> 
> while i don't know OF1.5 spec details, the code itself looks
> reasonable to me.
> 
> Acked-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>

Thanks.

I'll rerun the tests and then push the patches to this point.



More information about the dev mailing list