[ovs-dev] [PATCH v2] lib/netdev-windows.c: nuke the init function

Ben Pfaff blp at nicira.com
Wed Oct 8 15:27:00 UTC 2014


On Tue, Oct 07, 2014 at 05:21:04PM -0700, Nithin Raju wrote:
> The init function is not allowed to call into the kernel datapath
> while running unit tests since the kernel datapath is not loaded.
> Instead of making the function dummy, it is better to not have it
> at all.
> 
> Signed-off-by: Nithin Raju <nithin at vmware.com>
> Reported-by: Gurucharan Shetty <gshetty at nicira.com>

[...]
> -static int
> -netdev_windows_init(void)
> +static
> +netdev_windows_init_(void)

You should specify a return type, e.g. "int".

Thanks,

Ben.



More information about the dev mailing list