[ovs-dev] [PATCH] ovs-ofctl: Document protocol-specific forms as preferred over tp_src/tp_dst.

[Ben Pfaff]

On Tue, Oct 07, 2014 at 04:29:14PM -0700, Alex Wang wrote:
> Thx Ben for clearing this up,
> 
> Please see my comments below:
> 
> 
> > +.IP \fBtcp_src=\fIport\fR
> > +.IQ \fBtcp_dst=\fIport\fR
> > +.IQ \fBudp_src=\fIport\fR
> > +.IQ \fBudp_dst=\fIport\fR
> > +.IQ \fBsctp_src=\fIport\fR
> > +.IQ \fBsctp_dst=\fIport\fR
> > +Matches a TCP, UDP, or SCTP source or destination port \fIport\fR,
> > +which is specified as a decimal number between 0 and 65535, inclusive.
> > +.IP
> > +When \fBdl_type\fR and \fBnw_proto\fR are wildcarded or set to values
> > +that do not indicate an appropriate protocol, the values of these
> > +settings are ignored (see \fBFlow Syntax\fR above).
> >
> 
> 
> I checked on current master, if the prerequisite test failed, the flow is
> just discarded (not installed).

I mean something like this.  You can see that "ip,tcp_src=80" gets
changed into just "ip", which gets installed:

    blp at sigsegv:~/ovs/tutorial$ ovs-vsctl add-br br0
    blp at sigsegv:~/ovs/tutorial$ ovs-ofctl add-flow br0 ip,tcp_src=80,actions=drop
    2014-10-08T18:23:03Z|00001|ofp_util|INFO|normalization changed ofp_match, details:
    2014-10-08T18:23:03Z|00002|ofp_util|INFO| pre: ip,tp_src=80
    2014-10-08T18:23:03Z|00003|ofp_util|INFO|post: ip
    blp at sigsegv:~/ovs/tutorial$ ovs-ofctl dump-flows br0
    NXST_FLOW reply (xid=0x4):
     cookie=0x0, duration=187.334s, table=0, n_packets=0, n_bytes=0, idle_age=187, priority=0 actions=NORMAL
     cookie=0x0, duration=9.804s, table=0, n_packets=0, n_bytes=0, idle_age=9, ip actions=drop
    blp at sigsegv:~/ovs/tutorial$ 

Is there better wording?