[ovs-dev] [PATCH v1 5/6] datapath-windows: remove invalid assert.
Ankur Sharma
ankursharma at vmware.com
Fri Oct 10 06:02:23 UTC 2014
Assert(rc) would always hit for a valid case, hence
replaced it with error code based check.
Signed-off-by: Ankur Sharma <ankursharma at vmware.com>
---
datapath-windows/ovsext/Flow.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c
index b87e4e2..09bbb54 100644
--- a/datapath-windows/ovsext/Flow.c
+++ b/datapath-windows/ovsext/Flow.c
@@ -338,7 +338,10 @@ OvsFlowNlCmdHandler(POVS_USER_PARAMS_CONTEXT usrParamsCtx,
nlMsgHdr->nlmsgSeq, nlMsgHdr->nlmsgPid,
genlMsgHdr->cmd, OVS_FLOW_VERSION,
ovsHdr->dp_ifindex);
- ASSERT(rc);
+
+ if (rc != STATUS_SUCCESS) {
+ goto done;
+ }
/* Append OVS_FLOW_ATTR_STATS attribute */
if (!NlMsgPutTailUnspec(&nlBuf, OVS_FLOW_ATTR_STATS,
--
1.9.1
More information about the dev
mailing list