[ovs-dev] [RFC 01/10] dpif-netdev: Group statistics updates in the slow path

Ben Pfaff blp at nicira.com
Fri Oct 10 15:47:39 UTC 2014


On Wed, Oct 08, 2014 at 02:09:47PM -0700, Daniele Di Proietto wrote:
> This also fixes a memory leak if an upcall fails
> 
> Signed-off-by: Daniele Di Proietto <ddiproietto at vmware.com>

I generally prefer to separate bug fixes from other changes, when it is
not difficult.  Can the memory leak fix be a separate patch?

In the kernel datapath, a lost packet is counted against both the "miss"
and "lost" counters.  Before this patch, I think that was true for the
userspace datapath too.  After this patch, a lost packet is counted only
as "lost".  I'd prefer to keep that consistent.



More information about the dev mailing list