[ovs-dev] [RFC 01/10] dpif-netdev: Group statistics updates in the slow path

[Daniele Di Proietto]

On 10/10/14, 8:47 AM, "Ben Pfaff" <blp at nicira.com> wrote:

>On Wed, Oct 08, 2014 at 02:09:47PM -0700, Daniele Di Proietto wrote:
>> This also fixes a memory leak if an upcall fails
>> 
>> Signed-off-by: Daniele Di Proietto <ddiproietto at vmware.com>

Thanks for the all the reviews, Ben!

>
>I generally prefer to separate bug fixes from other changes, when it is
>not difficult.  Can the memory leak fix be a separate patch?

Sure, I split those commits.

>
>In the kernel datapath, a lost packet is counted against both the "miss"
>and "lost" counters.  Before this patch, I think that was true for the
>userspace datapath too.  After this patch, a lost packet is counted only
>as "lost".  I'd prefer to keep that consistent.

I was not aware of that. Fixed.