[ovs-dev] [RFC 05/10] ovs-thread-stats: New truly per-thread stats module

Ben Pfaff blp at nicira.com
Fri Oct 10 23:35:40 UTC 2014


On Fri, Oct 10, 2014 at 09:59:55PM +0000, Daniele Di Proietto wrote:
> 
> 
> On 10/10/14, 9:42 AM, "Ben Pfaff" <blp at nicira.com> wrote:
> >
> >I thought of another question.  I think that there's a hard limit, with
> >this mechanism, on the maximum size of the client's statistics data
> >structure.  Without looking at the patch again, I think it's 64 - 8 = 56
> >bytes.  Is there anything in the code to make it hard for the client to
> >accidentally try to store more data than that?
> 
> I didn't want to force the users to write a BUILD_ASSERT for each
> structure they use, so I "hid" it in OVSTHREAD_STATS_BUCKET_CAST. Do you
> think that's enough?

I missed that on first read.  It is a good solution, thank you.



More information about the dev mailing list