[ovs-dev] [PATCH v1 1/6] datapath-windows: Transactional error support in Flow commands.

[Nithin Raju]

On Oct 9, 2014, at 11:02 PM, Ankur Sharma <ankursharma at vmware.com>
 wrote:

> In this patch we added the code to handle transactional errors
> in flow commands.
> 
> Signed-off-by: Ankur Sharma <ankursharma at vmware.com>

Ankur,
Thanks for the fixes.

One general comment is that, you seem to be returning a transactional error even for ioctl errors such as invalid buffer size, etc. The approach in the other transactional functions is that we return a transactional error (and NTSTATUS for ioctl return code), only when all the arguments are valid and the kernel cannot service the request for some reason. Eg. the port not found in which case, we return NL_ERROR_NODEV or NL_ERROR_NOTSUPP.

I am not sure which is the right approach. But, it might make sense to keep the functions consistent and then apply a consistent policy across them at some point.

thanks,
-- Nithin