[ovs-dev] [PATCH v1 3/6] datapath-windows: Reply for Flow Flush.

Nithin Raju nithin at vmware.com
Sat Oct 11 19:12:07 UTC 2014


On Oct 11, 2014, at 12:11 PM, Nithin Raju <nithin at vmware.com>
 wrote:

> On Oct 9, 2014, at 11:02 PM, Ankur Sharma <ankursharma at vmware.com>
> wrote:
> 
>> Added changes to send a reply for FLOW_FUSH case. This is needed
>> as with nithin's transaction reply changes we'll need reply for each
>> command.
>> 
>> Signed-off-by: Ankur Sharma <ankursharma at vmware.com>
> 
> Generally, I have not seen the practice of quoting a developer directly in the commit message. You might want to say that there are pending changes that make transactional reply mandatory when ioctl return status is SUCCESS.
> 
> Also, I have seen the practice of adding a "Reported-by" if someone reported the issue.


Change looks good otherwise.

Acked-by: Nithin Raju <nithin at vmware.com>


More information about the dev mailing list