[ovs-dev] [PATCH 1/4] Upcall NL packet format: Add NL utilities

Eitan Eliahu eliahue at vmware.com
Tue Oct 14 20:03:45 UTC 2014


Hi Nithin,
I don't have a strong opinion on the names, but I thought we want to keep NL utilities names as the Linux datapath.
Thank you,
Eitan

-----Original Message-----
From: Nithin Raju 
Sent: Tuesday, October 14, 2014 1:00 PM
To: Eitan Eliahu
Cc: <dev at openvswitch.org>
Subject: Re: [ovs-dev] [PATCH 1/4] Upcall NL packet format: Add NL utilities

Eitan,
Looks good but for the following comments.

> +UINT32
> +static __inline NlAttrSize(UINT32 payload)

Can we call this: NlAttrSizeForPayload() or NlAttrSizeForData? The reason is, there are existing APIs such as NlAttrLen() which operate on a nlattr. These functions that you are adding don't operate on an nlattr.

> +static __inline NlAttrTotalSize(UINT32 payload)

Can we call this: NlAttrTotalSizeForPayload() or NlAttrTotalSizeForData?

Acked-by: Nithin Raju <nithin at vmware.com>

-- Ntihin



More information about the dev mailing list