[ovs-dev] [PATCH] lib/classifier: Minimize critical section.

Jarno Rajahalme jrajahalme at nicira.com
Wed Oct 15 18:01:25 UTC 2014


I just reverted this patch. I had failed to compile it with clang, which revealed a thread safety annotation warning.

I’ll post a more complete patch later.

  Jarno

On Oct 14, 2014, at 1:35 PM, Jarno Rajahalme <jrajahalme at nicira.com> wrote:

> Pushed,
> 
> Thanks for the review!
> 
>  Jarno
> 
> On Oct 13, 2014, at 1:59 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
>> On Fri, Oct 10, 2014 at 04:18:45PM -0700, Jarno Rajahalme wrote:
>>> classifier_find_rule_exactly() only needs the mutex to protect the
>>> list traversal.  Subtables are already RCU protected.
>>> 
>>> Locking here can be eliminated completely when RCU list is available.
>>> 
>>> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
>> 
>> Acked-by: Ben Pfaff <blp at nicira.com>
> 




More information about the dev mailing list